[jira] [Commented] (APEXCORE-737) AppMaster does not shut down because numRequestedContainers becomes negative

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (APEXCORE-737) AppMaster does not shut down because numRequestedContainers becomes negative

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/APEXCORE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124245#comment-16124245 ]

ASF GitHub Bot commented on APEXCORE-737:
-----------------------------------------

vrozov closed pull request #535: APEXCORE-737 Increment numRequestedContainers instead of decrementing for an already allocated container
URL: https://github.com/apache/apex-core/pull/535
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


> AppMaster does not shut down because numRequestedContainers becomes negative
> ----------------------------------------------------------------------------
>
>                 Key: APEXCORE-737
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-737
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: Sanjay M Pujare
>            Assignee: Sanjay M Pujare
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> A previous fix (for APEXCORE-624) has introduced a regression where numRequestedContainers inside StreamingAppMasterService.execute() becomes negative because instead of incrementing numRequestedContainers it is being decremented under certain conditions as follows:
> While processing the YARN response of container allocation/release request, numRequestContainers is decremented by newAllocatedContainers.size()  (correctly). However in case of (alreadyAllocated == true) the decrement should be undone by incrementing numRequestContainers (i.e. numRequestContainers++). However the current code is decrementing again (i.e. numRequestContainers--) on line 886



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Loading...