[jira] [Resolved] (APEXCORE-737) AppMaster does not shut down because numRequestedContainers becomes negative

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Resolved] (APEXCORE-737) AppMaster does not shut down because numRequestedContainers becomes negative

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/APEXCORE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vlad Rozov resolved APEXCORE-737.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 3.7.0

> AppMaster does not shut down because numRequestedContainers becomes negative
> ----------------------------------------------------------------------------
>
>                 Key: APEXCORE-737
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-737
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: Sanjay M Pujare
>            Assignee: Sanjay M Pujare
>            Priority: Minor
>             Fix For: 3.7.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> A previous fix (for APEXCORE-624) has introduced a regression where numRequestedContainers inside StreamingAppMasterService.execute() becomes negative because instead of incrementing numRequestedContainers it is being decremented under certain conditions as follows:
> While processing the YARN response of container allocation/release request, numRequestContainers is decremented by newAllocatedContainers.size()  (correctly). However in case of (alreadyAllocated == true) the decrement should be undone by incrementing numRequestContainers (i.e. numRequestContainers++). However the current code is decrementing again (i.e. numRequestContainers--) on line 886



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Loading...